Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(front): Add mask annotations on video frames #220

Open
wants to merge 12 commits into
base: feat/init-video
Choose a base branch
from

Conversation

timothee-LJN
Copy link
Contributor

@timothee-LJN timothee-LJN commented Mar 28, 2024

Issue

Fixes #214

Description

  • This branch is pulled from feat(front): Create video player with annotations #185
  • To add mask to video, the data model had to evolve compared to feat(front): Create video player with annotations #185 since tracklets need to accept both bboxor mask
  • A tracklet is now an array of KeyVideoFrame, each can have a bbox or a mask
  • I would advise to check first datasetTypes.ts file to understand the data structure
  • The mask linear interpolation does not feel super snappy since we need to convert mask.count to svg and then to coordinates and then apply the simplifyJs API on each calculation. We also refer on array index to retrieve points, which is not working perfectly (causing sometimes the mask to turn around). Maybe this data structure should be given a second though?

@timothee-LJN timothee-LJN added the scope: front Related to Pixano frontend label Mar 28, 2024
@timothee-LJN timothee-LJN self-assigned this Mar 28, 2024
@timothee-LJN timothee-LJN changed the title feat: Add mask annotations on video frames feat(front): Add mask annotations on video frames Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: front Related to Pixano frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant