Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ci): Add backend linting #26

Merged
merged 25 commits into from
Jan 9, 2024
Merged

feat(ci): Add backend linting #26

merged 25 commits into from
Jan 9, 2024

Conversation

cpvannier
Copy link
Member

Description

Lint backend code using Pylint and add lint check in GitHub actions

Changes

Added

  • Add a GitHub action to check backend code linting with Pylint

Changed

  • Lint backend code using Pylint

@cpvannier
chore(ci): Lint Python code with Pylint
4975ff5
@cpvannier
feat(ci): Add backend lint action with Pylint
55f55f9 
Also split lint and format actions in two separate files
@cpvannier
fix(back): Fix typo in Importer after linting
758bd60
@cpvannier
chore(ci): Rename GitHub actions
37a2dc7
@cpvannier
chore(tests): Fix test function name
ac0f8fa
@cpvannier
chore(back): Fix checking optional args
defc986
@cpvannier
chore(ci): Lint Python code with Pylint
5a56bd6 
Remove temporarily disabled rules and fix issues

In order to split methods into more reasonably sized ones:
- Add create, create_table, _embeddings_search, _split_items to Dataset
- Add add_or_update_object, delete_objects to DatasetItem
- Add _export_item, _export_images, _export_object to COCOExporter
- Add copy_or_move_files to Importer
- Add create_table, _load_rows to InferenceModel
@cpvannier
chore(ci): Lint Python code in notebooks/
7b75d56
@cpvannier
fix(back): Fix InferenceModel
526e768
@cpvannier
fix(back): Fix loading embeddings
9b5d3a3
@cpvannier
chore(back): Update App docstring
22fcdf8
@cpvannier
fix: Revert onnxruntime version to 1.15
30a0bc1 
onnxruntime 1.16 causes issues when using SAM in Pixano Inference
@cpvannier
fix(back): Fix checking for embeddings tables
2e2cf9a
@cpvannier
chore(notebooks): Fix call to process_dataset
fe2c69d
@cpvannier
chore(back): Replace calls to lancedb update by add and delete
2d7e569 
Change needed for compatibility with lancedb 0.3.5+ which adds better support for update queries, but only for limited data types
@cpvannier
chore: Update lancedb and pylance versions
2b969dc 
Use '==' instead of '~=', as minor version updates to those dependencies can break Pixano, as seen in 2d7e569
@cpvannier
chore(tests): Lint backend tests
f0b3093
@cpvannier
feat(ci): Add backend tests to lint action
bb68f0c
@cpvannier
chore(ci): Merge formatting GitHub actions
281c95c 
Merge Jupyter formatting into backend format action
Merge Markdown and YAML formatting into frontend format action
@cpvannier
fix(ci): Fix dependencies for backend tests linting
d2936da
@cpvannier cpvannier added enhancement New feature or request scope: back Related to Pixano backend labels Jan 8, 2024
@cpvannier cpvannier self-assigned this Jan 8, 2024
@cpvannier cpvannier marked this pull request as ready for review January 8, 2024 16:00
BertrandRenault
BertrandRenault reviewed Jan 8, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@cpvannier cpvannier merged commit ccf8773 into develop Jan 9, 2024
10 checks passed
@cpvannier cpvannier added this to the Pixano 0.5.0 milestone Jan 16, 2024
@cpvannier cpvannier deleted the chore/lint_backend branch January 31, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrabary jrabary jrabary approved these changes

@timothee-LJN timothee-LJN timothee-LJN approved these changes

@BertrandRenault BertrandRenault BertrandRenault approved these changes

Assignees

@cpvannier cpvannier

Labels
enhancement New feature or request scope: back Related to Pixano backend
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cpvannier @jrabary @timothee-LJN @BertrandRenault