-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Fix Pixano deployed app #29
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Temporary rollback as newer versions of lancedb and lance currently cause issues when loading and saving items
Fixes routers not being to access shared settings when running the app in deployed mode or in unit tests
This comment was marked as resolved.
This comment was marked as resolved.
BertrandRenault
approved these changes
Jan 12, 2024
Add a model_dir attribute in app settings that is either local_model_dir in case of S3 library or data_dir / "models" in case of local library
This comment was marked as resolved.
This comment was marked as resolved.
timothee-LJN
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With the merge of Pixano Annotator and Explorer in #23 and #27, and the use of svelteKit with the new ImageWorkspace, running the Pixano deployed app is not yet working and needs to be fixed.
Warning: breaking change for local run
To run the backend locally you should now use
LIBRARY_DIR
instead ofDATA_DIR
(andpixano.app
instead ofpixano.apps
as of #27):And S3 parameters are now named:
endpoint_url
region_name
aws_access_key
aws_secret_key
local_model_dir
Using S3 datasets
For datasets on S3 storage, you can add the required parameters similarly to
LIBRARY_DIR
:For the deployed app installed with PyPI,
LIBRARY_DIR
is an argument while S3 parameters are options added to the command with--{option_name}
:For example:
Changes
Fixed