Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(front): Load embeddings only once a model is selected #53

Merged
merged 3 commits into from
Jan 23, 2024
Merged

fix(front): Load embeddings only once a model is selected #53

merged 3 commits into from
Jan 23, 2024

Conversation

timothee-LJN
Copy link
Contributor

fixes : pixano/pixano-project-manager#30

improve number of time we hit the api for :

  • loading new item
  • loading embeddings

@timothee-LJN timothee-LJN added the bug: minor Minor issues, minimal user impact label Jan 22, 2024
@timothee-LJN timothee-LJN self-assigned this Jan 22, 2024
cpvannier
cpvannier reviewed Jan 23, 2024
View reviewed changes
Copy link
Member

@cpvannier cpvannier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the dropdown list, If I click select one model, then select another, the LoadModelModal disappears before I can confirm my selection.

@timothee-LJN
Copy link
Contributor Author

@cpvannier it's corrected thanks for your feedback

@cpvannier cpvannier added the scope: front Related to Pixano frontend label Jan 23, 2024
@cpvannier cpvannier added this to the Pixano 0.5.0 milestone Jan 23, 2024
@timothee-LJN timothee-LJN merged commit 351f345 into develop Jan 23, 2024
5 checks passed
@timothee-LJN timothee-LJN deleted the fix/select-model-from-list branch January 23, 2024 09:19
@cpvannier cpvannier mentioned this pull request Jan 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpvannier cpvannier cpvannier approved these changes

@BertrandRenault BertrandRenault BertrandRenault approved these changes

Assignees

@timothee-LJN timothee-LJN

Labels
bug: minor Minor issues, minimal user impact scope: front Related to Pixano frontend
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@timothee-LJN @cpvannier @BertrandRenault