fix(back): use uuid instead of imported id, for items and objects. keep original id #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BertrandRenault
added
bug: minor
|
Some tests are based on id (original data id), so generating a shortuuid id breaks theses tests. |
|
It is probably best to access the table directly with Lance to retrieve the generated UUIDs. This will allow calling the endpoints in the same way that the frontend does, which is what we want to validate with these tests. |
BertrandRenault
changed the title
timothee-LJN
approved these changes
Jan 24, 2024
cpvannier
approved these changes
Jan 24, 2024
cpvannier
added
bug: major
cpvannier
pushed a commit
that referenced
this pull request
Feb 15, 2024
…ep original id (#55) * fix(back): coco_importer with uuid * fix(back): keep original_id, uuid for objects, all importers * fix(tests): adapt tests to uuid ids * fix(back): adapt tests + lookup in tables with id_list from first table select * fix(test): format * fix(back): if exists, export original_id to id * fix(back): make original_id generic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft for using shortuuid instead of original id in coco_importer, to ensure id unicity
should fix #50