feat(front): Create pre-annotation #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to PrimaryButton in PreAnnotation
cpvannier
reviewed
Jan 25, 2024
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
See pixano/pixano-project-manager#27 for more information on this issue
This comment was marked as resolved.
This comment was marked as resolved.
ui/components/imageWorkspace/src/components/SaveShape/SaveShapeForm.svelte
Outdated
Show resolved
Hide resolved
BertrandRenault
approved these changes
Jan 30, 2024
- Add ItemObject review_state attribute in backend - Rename ItemObject preAnnotation property to review_state in frontend - Update dataset.update_table() to create columns for new base fields like review_state in addition of new features
Replace all instances of gray colors by slate colors for consistency, as mentioned in #58 (comment)
As mentioned in #58 (comment)
Use Sketch template as guideline for how to display scene and object features. Display image metadata in the same way for consistency.
cpvannier
approved these changes
Jan 31, 2024
cpvannier
added a commit
that referenced
this pull request
Feb 15, 2024
* feat(front): Implement new design * refactor(front): Use generic form component to create new object * feat(front): Pre annotation layout * feat(front): Add disabled prop to PrimaryButton and bind isFormValid to PrimaryButton in PreAnnotation * fix(front): Refactor form inputs and add objectProperties binding * feat(front): Add switch to toggle preannotation pannel * feat(front): Pass objects to pre annotation (mocked) * feat(front): Highlight object being annotated * feat: Add initial values to form inputs * feat(front): Add or remove object when clicking buttons * feat(front): Display only object matching confidence slider * feat: Copy object in GT when pre annotation is accepted * feat(front): Flag rejected pre annotation as rejected * feat: Filter objects when they are annotated * refactor(front): Simplify API for annotation * feat(front): Save updated properties * feat: Save updated annotations * feat: Do not display rejected bbox * fix(front): Fix filtering pre annotation * fix: Use filtered objects to mutate store * fix(back): Fix null value for number features See pixano/pixano-project-manager#27 for more information on this issue * fix(back): Fix formatting * feat(back): Add review_state to ItemObject - Add ItemObject review_state attribute in backend - Rename ItemObject preAnnotation property to review_state in frontend - Update dataset.update_table() to create columns for new base fields like review_state in addition of new features * fix(back): Fix formatting * fix(front): Fix colors Replace all instances of gray colors by slate colors for consistency, as mentioned in #58 (comment) * fix(front): Fix language and case of SaveShapeForm As mentioned in #58 (comment) * fix(front): Fix display of scene and object features Use Sketch template as guideline for how to display scene and object features. Display image metadata in the same way for consistency. * feat(front): Update mask opacity when switching to pre annotation * fix(front): Clicking on model run does not hide pre annotation boxes --------- Co-authored-by: Corentin Vannier <corentin.vannier@cea.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR integrates the Pre-annotation feature:
How the data is processed: