Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(front): Keep modified points when creating a polygon #63

Merged
merged 3 commits into from
Jan 26, 2024

Conversation

timothee-LJN
Copy link
Contributor

bug description: when a polygon is being created and the user wants to drag a point to modify the new shape, the modification gets canceled once a new point is added.

This fixes the issue

@timothee-LJN timothee-LJN added the bug: minor Minor issues, minimal user impact label Jan 25, 2024
@timothee-LJN timothee-LJN self-assigned this Jan 25, 2024
@timothee-LJN timothee-LJN marked this pull request as draft January 25, 2024 15:36
@timothee-LJN timothee-LJN marked this pull request as ready for review January 25, 2024 16:04
@cpvannier cpvannier added this to the Pixano 0.5.0 milestone Jan 26, 2024
@cpvannier cpvannier added the scope: front Related to Pixano frontend label Jan 26, 2024
@timothee-LJN timothee-LJN merged commit 2d72d37 into develop Jan 26, 2024
5 checks passed
@timothee-LJN timothee-LJN deleted the fix/keep-modified-polygon-points branch January 29, 2024 08:55
cpvannier pushed a commit that referenced this pull request Feb 15, 2024
* fix(front): Keep modified points when creating a polygon

* fix(front): Add only newly created points to new polygon

* fix(front): Do not add undefined point when switching tool
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: minor Minor issues, minimal user impact scope: front Related to Pixano frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants