Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(back): Fix formatting for new stable version of black #64

Merged
merged 2 commits into from
Jan 29, 2024

Conversation

cpvannier
Copy link
Member

@cpvannier cpvannier commented Jan 26, 2024

Description

A new stable release of the black formatter has been released (24), which breaks the backend formatting GitHub action on the latest commit to develop (2d72d37) as our code is formatted with version 23.

  • Fix backend code formatting to be in line with version 24 of black
  • Specify version 24 of black in the GitHub action to prevent this from happening with future releases of black

Warning

For those working on the backend (@BertrandRenault), update your black formatter to version 24 as well:

pip install --upgrade black~=24.1.0

@cpvannier cpvannier added enhancement New feature or request scope: back Related to Pixano backend labels Jan 26, 2024
@cpvannier cpvannier added this to the Pixano 0.5.0 milestone Jan 26, 2024
@cpvannier cpvannier self-assigned this Jan 26, 2024
@cpvannier cpvannier merged commit a8bdf40 into develop Jan 29, 2024
5 checks passed
cpvannier added a commit that referenced this pull request Feb 15, 2024
* fix(back): Fix formatting for new stable version of black

* fix(ci): Specify black formatter version
@cpvannier cpvannier deleted the fix/black-formatting branch February 20, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request scope: back Related to Pixano backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants