feat(tests): Improve pixano.core unit tests #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpvannier
added
enhancement
timothee-LJN
approved these changes
Jan 31, 2024
BertrandRenault
approved these changes
Feb 1, 2024
cpvannier
added a commit
that referenced
this pull request
Feb 15, 2024
* fix(back): Fix DepthImage display method and unit tests * feat(tests): Add missing BBox unit tests * feat(tests): Add Camera and GtInfo unit tests * fix(back): Remove unused import * feat(back)!: Remove deprecated pyarrow_array_from_list function * feat(tests): Add missing test for is_binary * feat(tests): Add missing Image unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Only missing unit tests in pixano.core now are:
Image.complete_uri: assertRaises does not count in code coverage for some reasonImage.open(): Missing test for S3 image, should be doable with getmoto/motopixano_type.py: Testingconvert_field()andcreate_pyarrow_type()will require some work and deserves its own issue / PRWarning
This PR also removes the deprecated
pyarrow_array_from_list()function from pixano.core as it is no longer used anywhere.