chore(front): Refactor code to follow eslint rules #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- typescript-eslint/no-unsafe-argument mostly fixed, but can't add type annotations for events in Svelte code - typescript-eslint/no-strict-null-check already fixed - typescript-eslint/no-unnecessary-type-assertion fixed in 0887210
Ignore mask_utils.ts
There was a problem hiding this comment.
I did not comment on all type casting (const foo = bar as string - the as type part) but it should be avoided whenever we can. I think this article sums it up : https://dev.to/ylerjen/typescript-cast-is-a-type-breaker-1jbh
basicaly, if you cast a variable, you lose all confidence in TS. It sometimes means refactoring a bit though ! Let me know if you need some help !
Use the same ItemDetails interface for input and output API items
Rename for improved clarity
cpvannier
requested review from
timothee-LJN and
BertrandRenault
and removed request for
jrabary
Restore deleted code
Fix opening source/view labels by default when only one source/view
timothee-LJN
approved these changes
Nov 23, 2023
jrabary
approved these changes
Nov 23, 2023
cpvannier
added a commit
that referenced
this pull request
Nov 24, 2023
Previously done in format_bbox function in backend format_bbox was deleted in #7 to keep same format between front and back
cpvannier
added a commit
that referenced
this pull request
Nov 27, 2023
Previously done in format_bbox function in backend format_bbox was deleted in #7 to keep same format between front and back
cpvannier
added
scope: front
magwyz
pushed a commit
to magwyz/pixano
that referenced
this pull request
Dec 13, 2023
Previously done in format_bbox function in backend format_bbox was deleted in pixano#7 to keep same format between front and back
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor code to successfully pass eslint check with less rules disabled.
Changes
Added
Changed
Fixed