Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api)!: Send media files as URI links instead of base 64 encodings #8

Merged
merged 5 commits into from
Nov 27, 2023

Conversation

cpvannier
Copy link
Member

@cpvannier cpvannier commented Nov 23, 2023

Description

Send media files as URI links instead of base 64 encodings in Pixano API.

Allows for better speed and flexibility for more complex datasets, but drops support for datasets imported without copying media files (portable=False)

Changes

Changed

  • Breaking: Send media files as URI links instead of base 64 encodings in Pixano API. Allows for better speed and flexibility for more complex datasets, but drops support for datasets imported without copying media files (portable=False)
  • Remove the portable=False option from importers. Instead users can choose to either copy or move the media files to the dataset directory

BREAKING CHANGES:
- Drop support for datasets with external media directories
(datasets imported with portable=False)
Remove the `portable=False` option from importers
Instead users can choose to either copy or move the media files
@cpvannier cpvannier self-assigned this Nov 23, 2023
@cpvannier cpvannier merged commit 4d3672f into develop Nov 27, 2023
10 checks passed
@cpvannier cpvannier deleted the feat/media_uri branch December 5, 2023 12:27
@cpvannier cpvannier added scope: front Related to Pixano frontend enhancement New feature or request labels Dec 6, 2023
@cpvannier cpvannier changed the title feat(api)!: Send media files as URI instead of base 64 encodings feat(api)!: Send media files as URI links instead of base 64 encodings Dec 6, 2023
@cpvannier cpvannier added this to the Pixano 0.5.0 milestone Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request scope: front Related to Pixano frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants