Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(front): Reset search when changing dataset #84

Merged
merged 7 commits into from
Feb 2, 2024

Conversation

timothee-LJN
Copy link
Contributor

fixes : #72

description :

  • BUG FIXING : reset search when arriving on a dataset table page (which was causing the bug)
  • RELATED IMPROVEMENT : display error message when search is in error
  • RELATED IMPROVEMENT : fetch dataset items only once
image

@timothee-LJN timothee-LJN added bug: minor Minor issues, minimal user impact enhancement New feature or request scope: front Related to Pixano frontend labels Feb 1, 2024
@timothee-LJN timothee-LJN self-assigned this Feb 1, 2024
@timothee-LJN timothee-LJN merged commit 215d89f into develop Feb 2, 2024
5 checks passed
@cpvannier cpvannier added this to the Pixano 0.5.0 milestone Feb 7, 2024
@cpvannier cpvannier added bug: major Major issues, significant user impact and removed bug: minor Minor issues, minimal user impact labels Feb 14, 2024
@cpvannier cpvannier deleted the fix/count-issue-after-semanti-search branch February 15, 2024 14:18
cpvannier pushed a commit that referenced this pull request Feb 15, 2024
* refactor(front): Removed deprecated isManual flag for mask

* feat(front): Display error when search in dataset fails

* feat(front): Reset search query to default state when switching database

* feat(front): Do not fetch dataset items twice when landing on datasetExplorer page

* fix(front): Make dasbhoard data conditional

* feat(front): Do not show pagination if dataset search is in error state
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: major Major issues, significant user impact enhancement New feature or request scope: front Related to Pixano frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix page/item count issue after semantic search
3 participants