feat(front): remove inputs after validation/cancel #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat(back): Add ann_type to choose between "Pre-annotation" and "Model run" * fix(ci): Update Pylint local variables limit * feat(front): Update "Ignore" pre-annotation button to "Reject" As discussed during the latest sprint demo (Fri 02/02/2024), and for consistency with documentation in inference_model.py and pre_annotation.ipynb * fix(back): Make ann_type optional * fix(front): Update Prettier config for 3.2.5 See https://github.com/prettier/prettier/blob/main/CHANGELOG.md#use-json-parser-for-tsconfigjson-by-default-16012-by-sosukesuzuki * fix(back): Merge ann_type with process_type * fix(ci): Revert Pylint local variables limit
cpvannier
approved these changes
Feb 5, 2024
timothee-LJN
approved these changes
Feb 6, 2024
ui/components/imageWorkspace/src/components/SaveShape/SaveShapeForm.svelte
Outdated
Show resolved
Hide resolved
ui/components/imageWorkspace/src/components/SaveShape/SaveShapeForm.svelte
Show resolved
Hide resolved
cpvannier
added a commit
that referenced
this pull request
Feb 15, 2024
* feat(front): remove inputs after validation/cancel * feat(back): Choose Pre-annotation or Model run in InferenceModel (#91) * feat(back): Add ann_type to choose between "Pre-annotation" and "Model run" * fix(ci): Update Pylint local variables limit * feat(front): Update "Ignore" pre-annotation button to "Reject" As discussed during the latest sprint demo (Fri 02/02/2024), and for consistency with documentation in inference_model.py and pre_annotation.ipynb * fix(back): Make ann_type optional * fix(front): Update Prettier config for 3.2.5 See https://github.com/prettier/prettier/blob/main/CHANGELOG.md#use-json-parser-for-tsconfigjson-by-default-16012-by-sosukesuzuki * fix(back): Merge ann_type with process_type * fix(ci): Revert Pylint local variables limit * chore(front): linting * fix(front): equality test --------- Co-authored-by: Corentin Vannier <56968251+cpvannier@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove construction inputs after validation/cancel
Also allow "Escape" key along with cancel button
close #88