Updating sonar github action to also retrieve and upload hotspots #11
Conversation
dist/index.js
Outdated
There was a problem hiding this comment.
this file was uploaded just for testing purposes but it won't be merged
| const { prNumber } = getGitHubContext(); | ||
| const url = `${apiUrl}/issues/search?componentKeys=${encodeURIComponent( | ||
| componentKey | ||
| )}&resolved=false`; | ||
| )}&resolved=false&ps=${MAX_PAGE_SIZE}`; |
There was a problem hiding this comment.
Updating page size limit to 500
Issue: #10
src/action.ts
Outdated
| break; | ||
| case "sonar": | ||
| const issuesfile = await fetchOrLocateSonarResultsFile("issues"); | ||
| await uploadInputFile(tool, issuesfile); |
There was a problem hiding this comment.
This function call isn't quite correct anymore. In this case, instead of tool we need to pass "sonar_issues". The sonar parameter is still supported for now but has been deprecated since we need to differentiate between issues and hotspots.
There was a problem hiding this comment.
the purpose of that change is because of the way the URL is built and used to upload the files to pixee, right? @drdavella
There was a problem hiding this comment.
Yes that's right, Pixeebot stores sonar issues and sonar hotspots in separate buckets so we need to upload them to different endpoints.
Related issue: #7 and #10