Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📌 Pin Examples to Major Version #21

Merged
merged 1 commit into from
May 30, 2024

Conversation

gilday
Copy link
Contributor

@gilday gilday commented May 30, 2024

Instead of using no version or a specific minor version, pin examples to major version.

Instead of using no version or a specific minor version, pin examples to major version.
@gilday gilday requested a review from drdavella May 30, 2024 02:33
Copy link
Member

@drdavella drdavella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have any objection to this but in general doesn't Dependabot handle this kind of thing?

@gilday
Copy link
Contributor Author

gilday commented May 30, 2024

I don't have any objection to this but in general doesn't Dependabot handle this kind of thing?

Only if you both have Dependabot and have configured it to keep Actions up to date https://docs.github.com/en/code-security/dependabot/working-with-dependabot/keeping-your-actions-up-to-date-with-dependabot

If users want to pin their minor versions and let Dependabot take care of updating them, that's fine and they probably know what they're doing, but I think the default that we should recommend to the average user is to pin to the latest major version.

@gilday gilday merged commit c49e19f into main May 30, 2024
2 checks passed
@gilday gilday deleted the pin-sonar-example-to-major-version branch May 30, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants