ISS-1378 Make pixee/upload-tool-results-action Sonar Host URL Consistent With Sonar Actions #26

JesusCotlamee · 2024-06-06T19:17:34Z

Updated

The input name was changed from sonar-api-url to sonar-host-url to be consistent with Sonar tools.
The action was updated to tolerate trailing slashes in the host URL.
Documentation and examples were updated.

Evidence

https://github.com/JesusCotlamee/test-sonar-integration-with-app/actions/runs/9419565450/job/25949593733

Refs: ISS-1378-make-sonar-host-url-consistent-with-sonar-actions

src/sonar.ts

README.md

…constructed and add 'api' to url Refs: ISS-1378-make-sonar-host-url-consistent-with-sonar-actions

Refs: ISS-1378-make-sonar-host-url-consistent-with-sonar-actions

src/sonar.ts

…oud and SonarQube. Refs: ISS-1378-make-sonar-host-url-consistent-with-sonar-actions

Refs: ISS-1378-make-sonar-host-url-consistent-with-sonar-actions

src/sonar.ts

gilday

I messed up the requirements: we need to use the input name sonar-host-url (not sonar-host).

And we should make sure that we handle the case where SonarQube is hosted at some context e.g. https://acme.org/sonarqube/

README.md

action.yml

src/sonar.ts

__tests__/sonar.test.ts

src/sonar.ts

action.yml

Refs: ISS-1378-make-sonar-host-url-consistent-with-sonar-actions

JesusCotlamee added 2 commits June 6, 2024 13:03

feat(action): Sonar consistent with sonar actions

ccac90e

Refs: ISS-1378-make-sonar-host-url-consistent-with-sonar-actions

feat(action): Update documentation

1b5a468

Refs: ISS-1378-make-sonar-host-url-consistent-with-sonar-actions

JesusCotlamee requested review from gilday and fjpgtt June 6, 2024 19:17

feat(action): Remove 'api' from default property and update examples

2db6a6d

Refs: ISS-1378-make-sonar-host-url-consistent-with-sonar-actions

fjpgtt requested changes Jun 6, 2024

View reviewed changes

src/sonar.ts Outdated Show resolved Hide resolved

README.md Outdated Show resolved Hide resolved

JesusCotlamee added 3 commits June 6, 2024 16:46

feat(action): Remove ternary because it is not necessary when url is …

664344f

…constructed and add 'api' to url Refs: ISS-1378-make-sonar-host-url-consistent-with-sonar-actions

feat(action): Add log debug

8789bef

Refs: ISS-1378-make-sonar-host-url-consistent-with-sonar-actions

feat(action): deleted, used for testing purposes only

9c1afbf

Refs: ISS-1378-make-sonar-host-url-consistent-with-sonar-actions

JesusCotlamee requested a review from fjpgtt June 7, 2024 15:39

fjpgtt requested changes Jun 7, 2024

View reviewed changes

src/sonar.ts Outdated Show resolved Hide resolved

src/sonar.ts Show resolved Hide resolved

src/sonar.ts Outdated Show resolved Hide resolved

JesusCotlamee added 3 commits June 7, 2024 13:32

feat(action): “cloud” is removed because the logic applies to SonarCl…

a31b390

…oud and SonarQube. Refs: ISS-1378-make-sonar-host-url-consistent-with-sonar-actions

feat(action): deleted, used for testing purposes only

e4892fb

Refs: ISS-1378-make-sonar-host-url-consistent-with-sonar-actions

feat(action): delete URL, no need to

4819a88

Refs: ISS-1378-make-sonar-host-url-consistent-with-sonar-actions

JesusCotlamee requested a review from fjpgtt June 7, 2024 19:48

fjpgtt approved these changes Jun 7, 2024

View reviewed changes

src/sonar.ts Outdated Show resolved Hide resolved

gilday requested changes Jun 10, 2024

View reviewed changes

JesusCotlamee added 6 commits June 11, 2024 10:03

feat(action): add URL to sonar-host input

f7a3c39

Refs: ISS-1378-make-sonar-host-url-consistent-with-sonar-actions

feat(action): updated documentation

b1fed6a

Refs: ISS-1378-make-sonar-host-url-consistent-with-sonar-actions

feat(action): refactor buildSonarIssuesUrl and buildSonarHotspotsUrl

5beaec1

Refs: ISS-1378-make-sonar-host-url-consistent-with-sonar-actions

feat(action): Fix test

7ab8a7d

Refs: ISS-1378-make-sonar-host-url-consistent-with-sonar-actions

feat(action): Omitted '/'

755b2f1

Refs: ISS-1378-make-sonar-host-url-consistent-with-sonar-actions

feat(action): added new test for Sonar Host URL

f4e8f83

Refs: ISS-1378-make-sonar-host-url-consistent-with-sonar-actions

JesusCotlamee requested a review from gilday June 11, 2024 17:02

gilday approved these changes Jun 12, 2024

View reviewed changes

JesusCotlamee merged commit c0d4409 into main Jun 12, 2024
1 check passed

JesusCotlamee deleted the ISS-1378-make-onar-host-url-consistent-with-sonar-actions branch June 12, 2024 15:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ISS-1378 Make pixee/upload-tool-results-action Sonar Host URL Consistent With Sonar Actions #26

ISS-1378 Make pixee/upload-tool-results-action Sonar Host URL Consistent With Sonar Actions #26

JesusCotlamee commented Jun 6, 2024 •

edited by gilday

Loading

gilday left a comment

ISS-1378 Make pixee/upload-tool-results-action Sonar Host URL Consistent With Sonar Actions #26

ISS-1378 Make pixee/upload-tool-results-action Sonar Host URL Consistent With Sonar Actions #26

Conversation

JesusCotlamee commented Jun 6, 2024 • edited by gilday Loading

gilday left a comment

Choose a reason for hiding this comment

JesusCotlamee commented Jun 6, 2024 •

edited by gilday

Loading