feat(netlify): Disable deploy preview by default

pixelastic · Jan 21, 2021 · 789c908 · 789c908
1 parent d401f3e
commit 789c908
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 9 deletions.
diff --git a/modules/netlify/lib/__tests__/enable.js b/modules/netlify/lib/__tests__/enable.js
@@ -19,7 +19,7 @@ describe('norska-netlify > enable', () => {
     beforeEach(async () => {
       jest.spyOn(helper, 'hasToken').mockReturnValue();
       jest.spyOn(current, 'linkRepository').mockReturnValue();
-      jest.spyOn(current, 'setEnvVariables').mockReturnValue();
+      jest.spyOn(current, 'configureSite').mockReturnValue();
     });
     it('should fail early if no token', async () => {
       helper.hasToken.mockReturnValue(false);
@@ -32,10 +32,10 @@ describe('norska-netlify > enable', () => {
       await current.run();
       expect(current.linkRepository).toHaveBeenCalled();
     });
-    it('should set the env variables', async () => {
+    it('should configure the website', async () => {
       helper.hasToken.mockReturnValue(true);
       await current.run();
-      expect(current.setEnvVariables).toHaveBeenCalled();
+      expect(current.configureSite).toHaveBeenCalled();
     });
   });
   describe('linkRepository', () => {

diff --git a/modules/netlify/lib/enable.js b/modules/netlify/lib/enable.js
@@ -25,7 +25,7 @@ module.exports = {
       return false;
     }
 
-    await this.setEnvVariables();
+    await this.configureSite();
   },
   /**
    * Link the current repository to a Netlify site
@@ -81,11 +81,13 @@ module.exports = {
     return `NETLIFY_AUTH_TOKEN (${siteName})`;
   },
   /**
-   * Set the required ENV variables on Netlify
-   * NETLIFY_AUTH_TOKEN: Newly generated token to cancel the build
-   * NODE_ENV: Set to prod to not install devDependencies
+   * Configure the Netlify site with the following settings:
+   * - Disable deploy preview
+   * - Set the required ENV variables on Netlify
+   *    - NETLIFY_AUTH_TOKEN: Newly generated token to cancel the build
+   *    - NODE_ENV: Set to prod to not install devDependencies
    **/
-  async setEnvVariables() {
+  async configureSite() {
     const client = helper.apiClient();
     const siteId = await helper.siteId();
 
@@ -107,10 +109,11 @@ module.exports = {
       body: {
         build_settings: {
           env: newVars,
+          skip_prs: true,
         },
       },
     });
-    this.__consoleSuccess('Environment variables saved to Netlify');
+    this.__consoleSuccess('Netlify configured');
   },
   __run: run,
   __consoleInfo: consoleInfo,