Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thousands seperator for thousands #6

Merged
merged 3 commits into from
Jan 23, 2020
Merged

Thousands seperator for thousands #6

merged 3 commits into from
Jan 23, 2020

Conversation

jeyemwey
Copy link
Contributor

@pixeldesu pixeldesu self-requested a review January 22, 2020 23:21
pixeldesu
pixeldesu requested changes Jan 22, 2020
View reviewed changes
Copy link
Owner

@pixeldesu pixeldesu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside of the test comment that seemed to snuck in the filter function, everything looks fine. Once that is removed, it's ready to merge!

src/components/FeedItem.vue Outdated Show resolved Hide resolved
@pixeldesu
Copy link
Owner

LGTM 👍

@pixeldesu pixeldesu merged commit 1e6ce2d into pixeldesu:develop Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixeldesu pixeldesu Awaiting requested review from pixeldesu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jeyemwey @pixeldesu