Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Favorites/like, boosts/share, and comments are not federating #942

Closed
amal-fi-haq opened this issue Mar 3, 2019 · 6 comments
Closed

Favorites/like, boosts/share, and comments are not federating #942

amal-fi-haq opened this issue Mar 3, 2019 · 6 comments
Labels
🕸️ ActivityPub Federation-related issue

Comments

@amal-fi-haq
Copy link

amal-fi-haq commented Mar 3, 2019

Actual behavior

  1. PixelFed post (public) federates to followers outside PixelFed (in this case, Masto)
  2. Followed PixelFed shows up in Home Timeline (in this case, Masto)
  3. Masto sourced favorites, boosts, and comments are visible within Masto only and are NOT federated back to PixelFed post as likes, shares, and comments.
  4. PixelFed sourced likes, shares, and comments are NOT federated back to Masto and thus are not visible.

Expected behavior
3/4. Favorites/like, boosts/share, and comments are seen by both, inside PixelFed as well as outside (in the case, Masto)

Ultimate Desire:

  • Via Masto: To boost my federated PixelFed posts. I will then no longer have to x-post on Masto for people to see my work.

Additional Info
Mastodon 2.7.3
PixelFed 0.8.0rc1

@dansup, we discussed (follower-only) the matter a bit here:
https://toot.jeena.net/@jeena/101649599404705942

@dansup dansup added the ⚙️ Deployment Related to specific deployments or configurations label Mar 3, 2019
@trwnh trwnh added 🕸️ ActivityPub Federation-related issue ⚙️ Deployment Related to specific deployments or configurations and removed ⚙️ Deployment Related to specific deployments or configurations labels Mar 3, 2019
@trwnh
Copy link
Member

trwnh commented Mar 3, 2019

You can track the progress of ActivityPub implementation in the pinned issue #5. To my current knowledge, the following are working (at least on whatever pixelfed.social deploys):

  • Making a post sends an outgoing status visible in Masto (your 1st point)
  • Following a Pixelfed user from Masto generally works (your 2nd point), but with one bug right now being Cannot follow an account that has ever been private or previously followed #866
  • Incoming likes/unlikes from Masto are added to your posts, and incoming replies from Masto are received as comments (your 3rd point)
  • Commenting on a post sends an outgoing reply visible in Masto (your 4th point), there just isn't a visible mention embedded in the content for Masto. The addressing is still correct even if not visible.

So I think this is fixed in master, if not in 0.8.0rc1? @dansup should be able to confirm if this is correct.

@trwnh
Copy link
Member

trwnh commented Mar 3, 2019

Sample Pixelfed post and comment in Mastodon:
image

Sample following in Mastodon:
image

@amal-fi-haq
Copy link
Author

Both your samples are within my experience. It looks like comments from PixelFed are federating over to Masto.

  1. I need to amend point 4 by saying, "comments federate to Masto, but likes and shares do not." Additionally, deleting the comment on PixelFed does NOT delete it on Masto. 🤷‍♂️

  2. Based on your sample following of dansup from Masto, can you use your Masto account to comment on that photo? I would like to know if your comment properly propagates over to PixelFed. Further more, what of favorites and boosts? Do they show on his pixelfed?

Thanks for pointing me to ActivityPub Jobs #5. Looks like a lot some of what I am mentioning is a work in progress still. I need to look at that list more carefully later.

I'm a bit ignorant with most of this and wish to be helpful. I want to avoid creating any new or duplicate issues when there is no need. Thanks for your patience. I love this project and what you all are doing.

@trwnh
Copy link
Member

trwnh commented Mar 4, 2019

I guess this issue can be closed as a duplicate, then -- it's ok though, if you have any questions you can ask them and we can redirect you to where you should look :) I see you already found #737 as the tracker issue for Deletes specifically, as well.

To answer your specific questions:

  1. Liking an incoming comment does not federate out yet, yeah. There's no way to reshare a comment yet.
  2. I can comment on a Pixelfed post using my Masto account, but only if I reply to the top-level post in the Masto thread (the one that corresponds to the actual post). This is due to the lack of a thread resolver right now.

@trwnh trwnh closed this as completed Mar 4, 2019
@trwnh trwnh modified the milestone: 0.8.0 Mar 4, 2019
@amal-fi-haq

This comment has been minimized.

@Whaxion
Copy link
Contributor

Whaxion commented Mar 4, 2019

I've made some investigations.
The masto comment as been catch by my instance, it's visible on the admin Statuses list. So, apparently, this comment isn't linked to the post.

@trwnh trwnh removed the ⚙️ Deployment Related to specific deployments or configurations label Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🕸️ ActivityPub Federation-related issue
Projects
None yet
Development

No branches or pull requests

4 participants