Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ActivityPub Jobs #5

Closed
24 of 41 tasks
dansup opened this issue May 17, 2018 · 9 comments
Closed
24 of 41 tasks

ActivityPub Jobs #5

dansup opened this issue May 17, 2018 · 9 comments
Assignees
@dansup
Labels
🕸️ ActivityPub Federation-related issue 💨 Performance Something is slow or could be faster ❗❗ Priority: High Important 💼 WIP This is currently being worked on
Milestone
0.13.0 - Federati...

Comments

@dansup
Copy link
Member

dansup commented May 17, 2018 •
edited by trwnh

  • SharedInbox Listener
  • InboxWorker (Responds to inbox requests)
  • SharedInboxWorker
  • RemoteFollowImport (Imports last 9 images for new remote profiles)
  • Accept/Reject Workers

Incoming:

  • Posts: Create Note should be visible in your timeline
  • Comments: Create Note.inReplyTo should be visible on your post
  • Delete post: Delete Note should remove a post from your timeline
  • Delete comment: Delete Note.inReplyTo should remove a comment from your post
  • Update post: Update Note should change caption/metadata of post in your timeline
  • Update comment: Update Note.inReplyTo should change text of comment on your post
  • Like post: Like Note should +1 the likes count and add their account to the likes list on your post
  • Like comment: Like Note.inReplyTo should +1 the likes count and add their account to the likes list on your comment
  • Unlike post: Undo Like Note should -1 the likes count and remove their account from the likes list on your post
  • Unlike comment: Undo Like Note.inReplyTo should -1 the likes count and remove their account from the likes list on your comment
  • Boost post: Announce Note should +1 the reshare count and add their account to the boosted list on your post
  • Boost comment: Announce Note.inReplyTo should +1 the reshare count and add their account to the boosted list on your comment
  • Unboost post: Undo Announce Note should -1 the reshare count and remove their account from the boosted list on your post
  • Unboost comment: Undo Announce Note.inReplyTo should -1 the reshare count and remove their account from the boosted list on your comment
  • Follow: Follow should send an outgoing Accept Follow, add their account to your follower list, and start delivering to their inbox
  • Follow approved: Accept Follow should start showing their posts in your feed, and add their account to your following list
  • Unfollow: Undo Follow should remove their account from your follower list and stop delivering to their inbox
  • Force-unfollow (e.g. when blocked): Reject Follow should remove their account from your follower list and their posts from your feed
  • Block: Block should prevent you from following, liking, resharing, or commenting them

Outgoing:

  • Posts: Create Note should be delivered to their inbox and show up in their feed
  • Comments: Create Note.inReplyTo should be delivered to their inbox and show up in a thread
  • Delete post: Delete Note should be delivered to their inbox and remove a post from the feed
  • Delete comment: Delete Note.inReplyTo should be delivered to their inbox and remove a comment from a thread
  • Update post: Update Note should be delivered to their inbox and change the contents of a post (if supported)
  • Update comment: Update Note.inReplyTo should be delivered to their inbox and change the contents of a comment (if supported)
  • Like post: Like Note should be delivered to their inbox and locally add a post to your liked posts
  • Like comment: Like Note.inReplyTo should be delivered to their inbox and locally add a comment to your liked comments
  • Unlike post: Undo Like Note should be delivered to their inbox and locally remove a post from your liked posts
  • Unlike comment: Undo Like Note.inReplyTo should be delivered to their inbox and locally remove a comment from your liked comments
  • Boost post: Announce Note should be delivered to their inbox and locally add their post to your reshares
  • [-] Boost comment: Announce Note.inReplyTo should be delivered to their inbox and locally add their comment to your reshares (unnecessary in Pixelfed?)
  • Unboost post: Undo Announce Note should be delivered to their inbox and locally remove their post from your reshares
  • [-] Unboost comment: Undo Announce Note.inReplyTo should be delivered to their inbox and locally remove their comment from your reshares (unnecessary in Pixelfed?)
  • Follow: Follow should wait for an incoming Accept Follow
  • Follow approved: Accept Follow should be delivered to their inbox to let them know the follow was successful
  • Unfollow: Undo Follow should be delivered to their inbox, remove their account from your following list, and remove their posts from your feed
  • Force-unfollow (e.g. when blocked): Reject Follow should be delivered to their inbox, remove their account from your follower list, and stop delivering posts to their inbox.
  • Block: Block should be delivered to their inbox (debatable -- perhaps optional?), and then immediately be followed up by an outgoing Reject Follow; incoming activities from that account should be discarded and return a Reject Activity that gets delivered to their inbox.
@trwnh
Copy link
Member

trwnh commented May 20, 2018 •
edited

Possibly missing?

  • Like Comment -> Announce

@dansup
Copy link
Member Author

dansup commented May 20, 2018

@trwnh I don't think its possible to like a comment on Instagram?

@trwnh
Copy link
Member

trwnh commented May 20, 2018

It's been possible since 2016: https://later.com/blog/like-instagram-comments/

The more pressing reason would be to support comment federation; commenting on an image post is the same as replying to a text post.

@dansup
Copy link
Member Author

dansup commented May 20, 2018

@trwnh Thanks, I will add that to the roadmap.

@dansup dansup self-assigned this May 26, 2018
@dansup dansup added 🕸️ ActivityPub Federation-related issue 💨 Performance Something is slow or could be faster ❗❗ Priority: High Important 💼 WIP This is currently being worked on labels May 26, 2018
@dansup dansup added this to the 0.1.0 milestone May 27, 2018
@trwnh trwnh mentioned this issue Aug 21, 2018
Closed
@dadall
Copy link

dadall commented Sep 17, 2018

Hey @dansup, is it up to date ?

@urtzai urtzai mentioned this issue Nov 29, 2018
Closed
@arjenpdevries
Copy link

Remote follow from Mastodon does not work yet.

@tribela
Copy link

tribela commented Jan 1, 2019 •
edited by trwnh

Deleting post is not forwarded to other servers.

(edit by @trwnh: both incoming and outgoing Deletes are not yet supported)

@dansup dansup removed this from the 0.1.0 milestone Feb 9, 2019
@trwnh trwnh pinned this issue Mar 3, 2019
@dansup dansup added this to the 0.8.0 milestone Mar 3, 2019
@trwnh trwnh mentioned this issue Mar 3, 2019
Closed
@joenepraat joenepraat mentioned this issue Mar 7, 2019
Closed
@ghost
Copy link

ghost commented Apr 2, 2019

Hello,

InboxWorker is failing on 0.8.4:
Screenshot 2019-04-02 at 14 28 37

@ghost
Copy link

ghost commented Apr 8, 2019

Hello,

InboxWorker is failing on 0.8.4:
Screenshot 2019-04-02 at 14 28 37

Does someone know if it is related? The problem occurs on the last versions too.

@trwnh trwnh mentioned this issue Jun 27, 2019
Open
@raphgilles raphgilles mentioned this issue Jul 22, 2019
Closed
@dermike dermike mentioned this issue Aug 12, 2019
Closed
dansup pushed a commit that referenced this issue Sep 9, 2019
@okpierre
Merge pull request #5 from pixelfed/dev
4b9dab5 
Sync June 28
@hyde-stevenson hyde-stevenson mentioned this issue Nov 4, 2019
Closed
@dansup dansup closed this as completed Jan 23, 2020
@dansup dansup unpinned this issue Jan 23, 2020
This was referenced Feb 15, 2020
Closed
Closed
@Progi1984 Progi1984 mentioned this issue Mar 16, 2021
Open
@SathyaBhat SathyaBhat mentioned this issue Sep 5, 2021
Closed
@Barkoczy Barkoczy mentioned this issue Aug 30, 2022
Closed
@aneillans aneillans mentioned this issue Oct 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dansup dansup

Labels
🕸️ ActivityPub Federation-related issue 💨 Performance Something is slow or could be faster ❗❗ Priority: High Important 💼 WIP This is currently being worked on
Projects
None yet
Milestone
0.13.0 - Federation Update
Development

No branches or pull requests
5 participants
@arjenpdevries @dansup @dadall @tribela @trwnh