Don't always explode the TRUST_PROXIES variable #1941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add S3 + Stories
Update StoryController, fix postgres bug + new translations
Update changelog
Update StoryController
Update Timeline.vue, restore notification card
Revert StoryController update
Add StoryTimelineComponent.vue
Update StoryController
Update StoryController
Update StoryController
Update settings home view, fixes pixelfed#1914
Update AccountTransformer, re-add header_bg field. Fixes pixelfed#1933
Update StoryController, fix postgres bug
dansup
requested changes
Jan 17, 2020
dansup
approved these changes
Jan 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the trustedproxy middleware checks the proxy variable against '*' and '**' directly, pixelfed should preserve those values as strings, rather than exploding them into arrays of strings.
This solves my issue with a load-balancer in front of pixelfed.