fix: add opt of forceScheme(https) #3710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running the application locally with
APP_URL=http://localhost it is unexpected for
all route URLs returned by `route('route-name')`
to use the https prefix.
Configuring SSL for your local environment should
not be a required step to development locally.
The new logic checks the configured URL for presence
of https:// OR that this the application is running
in a production environment.
thisislawatts
force-pushed
the
fix/opt-out-of-forcing-https
branch
from
39579f6
to
d1dca5a
Compare
|
@thisislawatts Thanks for the PR, this isn't the ideal way to disable it as there could be situations where your running in production and still want to disable it so I'll merge this and update it a bit to use the |
dansup
added a commit
that referenced
this pull request
Dec 2, 2022
yourivdlans
pushed a commit
to yourivdlans/pixelfed
that referenced
this pull request
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running the application locally with
APP_URL=http://localhost it is unexpected for
all route URLs returned by
route('route-name')to use the https prefix.
Configuring SSL for your local environment should
not be a required step to development locally.
The new logic checks the configured URL for presence
of https:// OR that this the application is running
in a production environment.
I have not worked with Laravel before, so very open to pointers
for alternative places this could be handled. 馃