Modal for posting new posts #86
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
hellcp
commented
Jun 1, 2018
hellcp
commented
82 tasks
|
Seems like it requires JS, but “javascript is just a progressive enhancement in PixelFed”… Using for previous card is a good idea… |
|
@m4sk1n it's enabled through js too, so it will only change to modal mode if you got js ;) |
|
@hellcp Nice work! Would you mind updating this PR to change the resources/views/timeline/partial/new-form.blade.php view instead of the personal/public timeline views? |
dansup
added
question
👀 UI
|
Will continue in other PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.