Implemented delete vector function based on the ID

[erramuzpe]

This is a PR trying to solve #42 and #27 . I've only done the one for Memory storage, since I don't know much about Redis.

I was trying to squash the previous commits and after some fails, decided to just start doing it properly (branching...).

[amorgun]

#56 (comment)

[amorgun]

hashes = [UniBucket('name_hash_%d' % k) for k in range(10)]

[amorgun]

You return keys from the first bucket of the first hash and it makes your second test really weird. If you want to get all data stored in the engine you should union content of all buckets for all hashes.

[erramuzpe]

Aw, you're right... It was fine before. I will take a look later on, ok? Thanks for your help!

[amorgun]

Something like that:

def get_keys(self, engine):
    def get_bucket_keys(lshash):
        bucket = engine.storage.buckets[lshash.hash_name][lshash.hash_name]
        return (i for v, i in bucket)
    return set(itertools.chain.from_iterable(
        get_bucket_keys(lshash) for lshash in engine.lshashes))

edit: less hacky get_bucket_keys

[erramuzpe]

That's fantastic!

[amorgun]

Still too long. Try this:

    def delete_vector(self, hash_name, data):
        """
        Deletes vector and JSON-serializable data in bucket with specified key.
        """
        for bucket in self.buckets[hash_name].values():
            bucket[:] = [(v, data) for v, data in bucket if data != data]

[erramuzpe]

Craftman work ❤️

[erramuzpe]

@amorgun did you do it by your own or is there a tool that factors it automatically? Would you recommend me resources (books, videos...) for good practices? (I mean, testing, PEP8...)

[amorgun]

@erramuzpe I did it by my own.
I personally use PyCharm. It helps with simple code analysis like pep8 and Python 2/3 compatibility and also allows some simple refactorings. And it has free community version. There are plenty of other linters for Python.
I suggest reading "Writing Idiomatic Python" by Jeff Knupp first, it's an essential book for beginners.
Next you can try Python Cookbook. It's more complicated, but it covers almost everything that can be done in Python, including testing.

[amorgun]

Looks good to me. Let's summon @pixelogik.

[adityapatadia]

Need to implement for redis too. We can't leave the storage without that method.

[adityapatadia]

https://redis-py.readthedocs.io/en/latest/#redis.StrictRedis.delete this should help.