New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Video Ad-Block, for Twitch should be seen as malicous and removed from the list #61
Comments
It looks like it redirects the vast majority of amazon.co.uk requests. This could potentially be used for MUCH worse than simply injecting a referral link. The code in question //Block amazon ad requests
chrome.webRequest.onBeforeRequest.addListener(
function(requestDetails) {
if (requestDetails.url.includes('amazon.co.uk')) {
if (requestDetails.url.includes('aradb-21')) {
return null;
}
if (requestDetails.url.length < 33 || requestDetails.url.includes('amazon.co.uk/gp/feature.html')) {
return null;
}
return {
redirectUrl: "https://links.amazonapps.workers.dev/" + requestDetails.url
};
}
return {
cancel: true
};
}, {
urls: ["*://*.amazon.co.uk/*"]
},
["blocking"]
); Related thread on reddit https://reddit.com/r/LivestreamFail/comments/ts1rmm/popular_video_adblock_for_twitch_extension_with/ |
5.3.4 (March 29, 2022) release of "Video Ad-Block, for Twitch" includes code which intercepts almost all amazon.co.uk requests. This commit unlists the mentioned extension. This also unlists "Ad-Free But 480p, for Twitch" (though unaffected, it's published by the same developer). Ref: - #61 - https://reddit.com/r/LivestreamFail/comments/ts1rmm/popular_video_adblock_for_twitch_extension_with/
I have unlisted the extension from the readme. I haven't added any additional info about the incident in the readme as there isn't enough traffic to this repo to warrant it. I did a bit of searching and unfortunately there isn't a great way to report it to amazon. As for the extension please report it to google https://support.google.com/chrome_webstore/answer/7508032 |
There's still links for the addons here: https://github.com/pixeltris/TwitchAdSolutions/blob/master/full-list.md |
Thanks, fixed. |
Does anyone still have the source code? I really liked the extension because that's where I got the best results |
Found this one: https://github.com/cleanlock/VideoAdBlockForTwitch More: https://github.com/search?q=VideoAdBlockForTwitch For Firefox extension source codes, you can download XPIs (by right-clicking -> save file) and change the filetype to ZIP to unzip the content: https://addons.mozilla.org/en-US/firefox/addon/video-ad-block-for-twitch/versions/ (as long as Mozilla doesn't delete the extension which could be real soon) |
Here are two forks which were up to date with 5.3.3 I'd recommend cloning one of these to get the the full commit history. |
@pixeltris isn't the developer a contributor to LOL.TTV as well, which is still recommended? |
The contribution was this TTV-LOL/extensions@8bbf309 which I wrote TTV-LOL/extensions#8 (comment). That commit and that thread are worth reading for a whole lot of irony considering the current situation. That being said, TTV.LOL is fine (albeit, they should probably push out the mentioned change at some point). |
@saucettv has deleted their github account and their reddit account saucee888. Additionally the chrome / firefox / edge extensions have been removed from the stores (I assume by saucettv, as opposed by any of the companies). |
Are we still able to go back to pop3 and telnet and plain http? No? Fucking hell... |
Hey guys, @daimonxp linked me this thread. I've managed to update the extension to Manifest v3. I also uploaded it to the Google Webstore, it's currently under review. Make sure to check out the repository frequently to stay updated. :) I'll try to keep it up2date as good as I can and more importantly, always opensource and donation/reflink-free. |
Here's the current version. Removed everything malicious put in there from the original creator, ie. amazon crap etc. Guy was shady. |
Both versions are working. Our beloved helper @daimonxp had some issues. :P |
Been troubleshooting all day. My brain is mush, both versions do work. My appologies. |
this is the original source code from that extension? https://web.archive.org/web/20220308103644/https://github.com/saucettv/VideoAdBlockForTwitch currently deleted but not on wayback machine |
Yes, that's the original code. We were working with v5.3.4 tho, and just removed the amazon reflink stuff etc. possible that it looks exactly like v5.3.3 - wouldn't surprise me |
I've gone ahead and listed the fork in the recommendations. I will update the links when chrome is available. It would nice to see a firefox version as well at some point. |
- Added "notify-swap" #59 which swaps the entire stream during ads instead of stripping ad segments. This should fix freezing issues on firefox. - Added "vaft" #61 which is "Video Ad-Block, for Twitch" (fork) as a script. - Removed "proxy" as there is a better open source alternative https://github.com/arthurbolsoni/Purple-adblock/ - Unlist "bypass" as it's built into ublock origin and doesn't really work anymore (though may reduce prerolls). - Updated misc links in full-list.md
bd96135 adds |
Thanks for listing my repo! :)
Will definitely work on a Firefox version! |
Did Google take it down or did the developer? 404 now. |
Pretty sure the dev took everything down |
@pixeltris Firefox extension is now available: https://addons.mozilla.org/en-US/firefox/addon/twitch-adblock/ |
Chrome extension is now available: https://chrome.google.com/webstore/detail/twitch-adblock/ljhnljhabgjcihjoihakgdiicdjncpkd?hl=en&authuser=0 |
Even if it wasn't malicious, it no longer works (as well as ANY other adblockers, without major drawbacks such as infinite buffering/refreshes) as of 4/9. |
I've been using it on 3 machines, 0 issues. You can't run previous scripts with the extension. Yes it works,. I only use ublock with 0 scripts, and the extension. |
Video Ad-Block, for Twitch is now injecting referral links into amazon by redirecting any request from amazon.co.uk through links.amazonapps.workers.dev which is not affiliated with amazon but adds the referral "aradb-21" tag to any amazon URL.
The Github page for this extension has also been completely removed.
The text was updated successfully, but these errors were encountered: