Fix negative table size calculation when socket tracer disabled via stirling flag #1894
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: When some or all of the tables
http_events, stirling_error, probe_status, proc_exit_events
are disabled via stirling flags (PL_STIRLING_SOURCES=...
) theother_table_size
calculation returns a negative output ifnum_tables < 4
. It also attempts division by zero whennum_tables = 4
This PR streamlines the table size calculation and fixes the edge condition.
Type of change: /kind bug
Test Plan: deployed to node and manually checked calculated table sizes.