Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for pod nodeSelector in helm and operator #362

Closed
wants to merge 2 commits into from

Conversation

smcavallo
Copy link
Contributor

vizier only runs on linux nodes.
add support for nodeSelector so consumers can restrict the pods where vizier can be run.
Signed-off-by: smcavallo smcavallo@hotmail.com

(@aimichelle - replaces #359)

Signed-off-by: smcavallo <smcavallo@hotmail.com>
@pixie-io-buildbot
Copy link
Member

Can one of the admins verify this patch?

Copy link
Member

@aimichelle aimichelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for the quick update! Just a few minor comments, but otherwise I think it's looking pretty good.
I'll separately patch this in and run a quick test. :)

src/api/proto/vizierconfigpb/vizier_types.proto Outdated Show resolved Hide resolved
src/operator/controllers/vizier_controller.go Show resolved Hide resolved
Signed-off-by: smcavallo <smcavallo@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants