combined No and Multiple selectors error detail components

pixiebrix · Feb 28, 2024 · a3aecd2 · a3aecd2
1 parent 7d82107
commit a3aecd2
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 45 deletions.
diff --git a/...rors/MultipleElementsFoundErrorDetail.tsx → ...nts/errors/InvalidSelectorErrorDetail.tsx b/...rors/MultipleElementsFoundErrorDetail.tsx → ...nts/errors/InvalidSelectorErrorDetail.tsx
@@ -16,11 +16,14 @@
  */
 
 import React from "react";
-import { type MultipleElementsFoundError } from "@/errors/businessErrors";
+import {
+  type NoElementsFoundError,
+  type MultipleElementsFoundError,
+} from "@/errors/businessErrors";
 import styles from "./ErrorDetail.module.scss";
 
-const MultipleElementsFoundErrorDetail: React.FunctionComponent<{
-  error: MultipleElementsFoundError;
+const InvalidSelectorErrorDetail: React.FunctionComponent<{
+  error: MultipleElementsFoundError | NoElementsFoundError;
 }> = ({ error: { message, selector } }) => (
   <div className={styles.root}>
     <div className={styles.column}>
@@ -34,4 +37,4 @@ const MultipleElementsFoundErrorDetail: React.FunctionComponent<{
   </div>
 );
 
-export default MultipleElementsFoundErrorDetail;
+export default InvalidSelectorErrorDetail;
diff --git a/src/components/errors/NoElementsFoundErrorDetail.tsx b/src/components/errors/NoElementsFoundErrorDetail.tsx
diff --git a/src/components/errors/getErrorDetails.tsx b/src/components/errors/getErrorDetails.tsx
@@ -32,8 +32,7 @@ import {
   ProxiedRemoteServiceError,
 } from "@/errors/businessErrors";
 import RemoteApiErrorDetail from "@/components/errors/RemoteApiErrorDetail";
-import MultipleElementsFoundErrorDetail from "@/components/errors/MultipleElementsFoundErrorDetail";
-import NoElementsFoundErrorDetail from "@/components/errors/NoElementsFoundErrorDetail";
+import InvalidSelectorErrorDetail from "@/components/errors/InvalidSelectorErrorDetail";
 
 type ErrorDetails = {
   title: string;
@@ -46,7 +45,7 @@ export default function getErrorDetails(error: ErrorObject): ErrorDetails {
     return {
       title: "No elements found for selector",
       detailsElement: (
-        <NoElementsFoundErrorDetail error={noElementsFoundError} />
+        <InvalidSelectorErrorDetail error={noElementsFoundError} />
       ),
     };
   }
@@ -59,7 +58,7 @@ export default function getErrorDetails(error: ErrorObject): ErrorDetails {
     return {
       title: "Multiple elements found for selector",
       detailsElement: (
-        <MultipleElementsFoundErrorDetail error={multipleElementsFoundError} />
+        <InvalidSelectorErrorDetail error={multipleElementsFoundError} />
       ),
     };
   }