Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nominal typing for ids #1076

Closed
twschiller opened this issue Aug 15, 2021 · 0 comments · Fixed by #1077
Closed

Nominal typing for ids #1076

twschiller opened this issue Aug 15, 2021 · 0 comments · Fixed by #1077
Assignees
@twschiller
Labels
developer experience

Comments

@twschiller
Copy link
Contributor

Context

  • We have two different kinds of ids floating around: UUIDs (surrogate keys) and registry ids
  • These are all labelled as string
  • Even with type aliases, it there would be inconsistent reporting of the type in the IDE
@twschiller twschiller self-assigned this Aug 15, 2021
twschiller added a commit that referenced this issue Aug 15, 2021
@twschiller
#1076: nominal subtyping for ids
ef6233f
@twschiller twschiller mentioned this issue Aug 15, 2021
Merged
@twschiller twschiller changed the title Nominal subtyping for ids Nominal typing for ids Aug 15, 2021
twschiller added a commit that referenced this issue Aug 15, 2021
@twschiller
#1076: fix brick cache; bail on generate headers if no headers generated
e1f8250
twschiller added a commit that referenced this issue Aug 15, 2021
@twschiller
#1076: remove unused extension point header code
3907c71
twschiller added a commit that referenced this issue Aug 15, 2021
@twschiller
#1076: nominal subtyping for ids (#1077)
77fe2a8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@twschiller twschiller

Labels
developer experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#1076: nominal subtyping for ids pixiebrix/pixiebrix-extension
1 participant
@twschiller