Support setting values of content editable div

[twschiller]

Context

• As a user, I'd like to use @pixiebrix/form-fill and @pixiebrix/forms/set to set the value of a div that's content editable

Implementation Sketch

• Modify the setValue method to detect if the element is a content editable div, and use the correct way of setting the value

Reference

• Missing setValue for div with contentEditable nightwatchjs/nightwatch#1210

Related

• Support setting multi-line values in textareas #1714

[fregante]

I don’t think this should be automatic based on contentEditable. If an element happens to be editable, it doesn't necessarily mean I want my HTML input to be parsed. For example the element could just be an editor like CodeMirror.

[twschiller]

I don’t think this should be automatic based on contentEditable

I'm not sure I'm following -- what do you mean by "my HTML input". Are you asking whether or not the user is trying to automatically change the value of the div? Or how the value might automatically be transformed before its value is applied?

With the @pixiebrix/form-fill and @pixiebrix/forms/set bricks, the intent of the user is that they want to change the value of some "input-like" element on the page. With the bricks we're trying to automatically to the right thing based on what kind of element it is, so that users don't have to understand the quirks of HTML

The context behind this issue is that some sites use content editable divs in their chat widgets, for the message the user wants to send

[fregante]

Oh, gotcha, the issue is that setValue uses .value = input whereas .textContent = input is needed. I assumed you were referring to innerHTML instead.

I'll work on this now, after I reproduce a bug I found today.

[twschiller]

Re-opening since it's not working on LinkedIn (see Loom/Slack)