Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapse doesn't work on sidebar toggled via Sidebar toggle brick #2308

Closed
twschiller opened this issue Jan 7, 2022 · 0 comments · Fixed by #2312
Closed

Collapse doesn't work on sidebar toggled via Sidebar toggle brick #2308

twschiller opened this issue Jan 7, 2022 · 0 comments · Fixed by #2312
Assignees
Labels
bug Something isn't working user experience Improve the user experience (UX)
Milestone

Comments

@twschiller
Copy link
Contributor

twschiller commented Jan 7, 2022

Federico, if you can't reproduce this, I'll try to isolate the issue

Steps to reproduce

  • Create a brick with two actions: 1) show sidebar, 2) show sidebar, 3) Reactivate all
  • Run it when the sidebar is not showing
  • Click the collapse button on the sidebar

Expected:

  • The sidebar disappears

Actual:

  • The sidebar doesn't disappear

Theories:

  • The sidebar might be on the page twice? If you click it twice it will disappear?
  • It might be the multiple show sidebars or the re-activate all
@twschiller twschiller added bug Something isn't working user experience Improve the user experience (UX) labels Jan 7, 2022
@twschiller twschiller added this to the 1.5.0 milestone Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working user experience Improve the user experience (UX)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants