Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Quick Bar item is showing up on all pages regardless of documentUrlPattern #2582

Closed
twschiller opened this issue Feb 4, 2022 · 1 comment · Fixed by #2585
Closed
Assignees
Labels
bug Something isn't working quickbar
Milestone

Comments

@twschiller
Copy link
Contributor

Steps to Reproduce

Expected behavior

  • The quick bar item is not shown because the URL doesn't match

Actual Behavior

  • The quick bar item is shown and can be run

Considerations

@twschiller twschiller added bug Something isn't working quickbar labels Feb 4, 2022
@twschiller twschiller added this to the 1.5.4 milestone Feb 4, 2022
@twschiller twschiller changed the title Custom Quick Bar item is showing up on all pages Custom Quick Bar item is showing up on all pages regardless of documentUrlPattern Feb 4, 2022
@fregante
Copy link
Collaborator

fregante commented Feb 4, 2022

I'm not sure of where this should be done. isAvailable is called and it returns false as expected, but then the item is still in this.extensions, an array of ResolvedExtension that does not have isAvailable nor documentUrlPattern, so I don't see a way to enforce that in registerExtensions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working quickbar
Projects
None yet
2 participants