Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary pop-up Slice 1: Add the “Display Temporary Information” brick #4464

Closed
twschiller opened this issue Oct 14, 2022 · 2 comments · Fixed by #4584
Closed

Temporary pop-up Slice 1: Add the “Display Temporary Information” brick #4464

twschiller opened this issue Oct 14, 2022 · 2 comments · Fixed by #4584
Assignees

Comments

@twschiller
Copy link
Contributor

twschiller commented Oct 14, 2022

[This issue was auto-generated using ProductBoard.]

#4464

You hit an API and then want to show the results of it, and it comes up only after the results come up (doesn't show up with blank sidebar).

Enables use cases where people want to build on hover over a term, hit an API, then shows additional context.

Draft specification: https://www.notion.so/pixiebrix/Ephemeral-Temporary-Document-Renderer-acd663a90fb64444ae372404ea6bda8a

This issue is for Slice 1 only.

  • Slice 1: add the “Display Temporary Information” brick

    • Add a new transformer brick “Display Temporary Information” that takes a:

      • Renderer pipeline argument. @pixiebrix/display

      • A title (string)

    • Add sidebarSlice temporaryPanels state to SidebarState

    • In sidebarController add a showRenderer method that’s called by the method

    • In the SidebarApp protocol, add a onShowRenderer method and wire up to redux in getConnectedListener

    • If a tab in the SidebarApp is for a temporaryPanel, add a close handle to the tab

  • Week 42: 5 points

  • Week 43: 2 points remain

@twschiller
Copy link
Contributor Author

@corinnemayans
Copy link
Contributor

Please post Loom to #sprint-demo when complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants