Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamic import module load failure in iframes #451

Closed
twschiller opened this issue Jun 8, 2021 · 1 comment · Fixed by #453
Closed

Dynamic import module load failure in iframes #451

twschiller opened this issue Jun 8, 2021 · 1 comment · Fixed by #453
Assignees
@twschiller
Labels
bug Something isn't working infrastructure urgent

Comments

@twschiller
Copy link
Contributor

twschiller commented Jun 8, 2021 •
edited
Loading

Problem

Version 1.1.6 introduced a problem when the module/bundle containing jq can't be loaded from the content script:

logging.ts:270 An error occurred: ContextError: Loading chunk vendors-node_modules_jq-web_jq_asm_bundle_min_js failed.

Is likely a compatibility problem between webpack 5 and https://github.com/crimx/webpack-target-webextension

Questions

  • Why is webpack producing both a jq-web.bundle.js and vendors-node_modules_jq-web_jq_asm_bundle_min_js.bundle.js?
  • It looks like this might be related to iframes -- the bundles are loading correctly in the top-level frame
@twschiller twschiller self-assigned this Jun 8, 2021
@twschiller twschiller added bug Something isn't working infrastructure urgent labels Jun 8, 2021
@twschiller twschiller changed the title jq module load failure Dynamic import module load failure Jun 8, 2021
@twschiller twschiller mentioned this issue Jun 8, 2021
Closed
@twschiller twschiller changed the title Dynamic import module load failure Dynamic import module load failure in iframes Jun 8, 2021
@twschiller
Copy link
Contributor Author

Opened an issue here: awesome-webextension/webpack-target-webextension#15

twschiller added a commit that referenced this issue Jun 8, 2021
@twschiller
#451: fix for dynamic module loading in modules
f1df105
@twschiller twschiller linked a pull request Jun 8, 2021 that will close this issue
#451: fix for dynamic module loading in modules #453
Merged
twschiller added a commit that referenced this issue Jun 8, 2021
@twschiller
#451: fix for dynamic module loading in modules (#453)
0fa1cbb
@twschiller twschiller mentioned this issue Jun 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@twschiller twschiller

Labels
bug Something isn't working infrastructure urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#451: fix for dynamic module loading in modules pixiebrix/pixiebrix-extension
1 participant
@twschiller