Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slice 5 - Config option for "Require only known headers" #7349

Closed
BLoe opened this issue Jan 16, 2024 · 0 comments · Fixed by #7360
Closed

Slice 5 - Config option for "Require only known headers" #7349

BLoe opened this issue Jan 16, 2024 · 0 comments · Fixed by #7360
Assignees
@BLoe

Comments

@BLoe
Copy link
Collaborator

BLoe commented Jan 16, 2024

Slice spec: https://www.notion.so/pixiebrix/Validate-Sheet-Structure-Headers-when-Appending-to-Google-Sheet-to-prevent-data-loss-fae6913966904f69aede80ccfc6215ee?pvs=4#3e38e610a13f484f85ea586731f5e22b
@BLoe BLoe self-assigned this Jan 16, 2024
@BLoe BLoe added this to the 1.8.7 milestone Jan 17, 2024
@grahamlangford grahamlangford changed the title GSheets Add Row sheet validation - Slice 5 - Config option for "Require only known headers" Slice 5 - Config option for "Require only known headers" Jan 17, 2024
@grahamlangford grahamlangford removed this from the 1.8.7 milestone Jan 17, 2024
@BLoe BLoe mentioned this issue Jan 17, 2024
Merged
3 tasks
BLoe added a commit that referenced this issue Jan 17, 2024
@BLoe
#7349 GSheets add row validation config slice 5 (#7360)
6c231fc 
* fix case when sheet is empty

* fix create tab logic and stop eating errors

* add new boolean to brick input, implement logic, and add toggle switch to append config options component

* add new boolean to brick input, implement logic, and add toggle switch to append config options component

* add tests

---------

Co-authored-by: Ben Loe <ben@pixiebrix.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BLoe BLoe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#7349 GSheets add row validation config slice 5 pixiebrix/pixiebrix-extension
2 participants
@BLoe @grahamlangford