Datadog sourcemaps not working in RainforestQA release builds

[twschiller]

Context

• Observed on 1.8.7-alpha.4

Discussion

• @johnnymetz you'll need to confirm which sourcemaps got uploaded for the actual release build
• The issues is there's a mismatch in domain between what gets called here:

  pixiebrix-extension/src/telemetry/initErrorReporter.ts

  Line 103 in 13f0d36

  location.origin + "/",

  and the upload triggered from here:

  pixiebrix-extension/.github/workflows/release.yaml

  Line 46 in 13f0d36

  - run: bash scripts/upload-sourcemaps.sh

• Upload uses the S3 URL, the code reporter rewrites stack traces to use extension://dynamichost/

Screenshots

[johnnymetz]

Both the mv2 and mv3 build logs show sourceMapPublicUrl is set:

• mv2: https://github.com/pixiebrix/pixiebrix-extension/actions/runs/7563418803/job/20595791849#step:5:28
• mv3: https://github.com/pixiebrix/pixiebrix-extension/actions/runs/7563418803/job/20595792088#step:5:28

So not sure how it's nullish here:

pixiebrix-extension/webpack.config.mjs

Lines 218 to 219 in 13f0d36

	SOURCE_MAP_PUBLIC_PATH:
	sourceMapPublicUrl ?? "extension://dynamichost/",

[twschiller]

cc @fregante

[fregante]

There is no dynamichost string in the zip file produced by that run (build-production.zip). Did you upload that bundle?

https://github.com/pixiebrix/pixiebrix-extension/actions/runs/7563418803

The error specifically mentions that string, so it must be present in the bundle, but which bundle? This isn't a Datadog config/upload issue yet

[fregante]

build-production.zip includes sourcemaps URLs like this one, which is valid and it exists:

//# sourceMappingURL=https://pixiebrix-extension-source-maps.s3.amazonaws.com/sourcemaps/build/c0e5cacc39b865790973c99cac04ebc523db8ecf/mv2/browserActionInstantHandler.js.map

[twschiller]

Hmm, not sure how these could get out of sync:

• Value that's submitted in errors comes from here:

  pixiebrix-extension/webpack.config.mjs

  Line 219 in 13f0d36

  sourceMapPublicUrl ?? "extension://dynamichost/",

• Value that's in the build comes from here:

  pixiebrix-extension/webpack.config.mjs

  Line 171 in 13f0d36

  publicPath: sourceMapPublicUrl,

There is no dynamichost string in the zip file produced by that run (build-production.zip). Did you upload that bundle?

Hmm, that's odd - that's a good place to dig into first. We'd expect to see that string somewhere in there

[johnnymetz]

Re-opening because this is still broken

[johnnymetz]

Running the rainforest qa job manually didn't work. The {{ github.sha }} value is b120c2a2470da2f478201204e8f878137a7361e9 which is not present in datadog (see here).

We may need to run the rainforest qa job as part of the release pipeline because the sha is dependent on the event that triggered the workflow, see docs:

The commit SHA that triggered the workflow. The value of this commit SHA depends on the event that triggered the workflow. For more information, see "Events that trigger workflows." For example, ffac537e6cbbf934b08745a378932722df287a53.

[fregante]

which is not present in datadog

Isn't that a matter of uploading the sourcemaps in the rainforest.yml workflow?

[twschiller]

Isn't that a matter of uploading the sourcemaps in the rainforest.yml workflow?

We could if we wanted too. I'm not aware there's any problems with uploading extra source maps to Datadog (e.g., if there's a max size across all maps/if we were to get billed for them)

[johnnymetz]

Still not working

[fregante]

Is their support helping? They can probably see what information they're missing and what we're doing wrong

[grahamlangford]

Is their support helping? They can probably see what information they're missing and what we're doing wrong

We've got an email chain with them that's been going on for a few weeks now. Most of the changes have been at their suggestion.

[twschiller]

Unassigning because it's in the icebox