Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve page editor responsive UI further #7558

Closed
fregante opened this issue Feb 7, 2024 · 3 comments · Fixed by #7976
Closed

Improve page editor responsive UI further #7558

fregante opened this issue Feb 7, 2024 · 3 comments · Fixed by #7976
Assignees
Labels
bug Something isn't working page editor

Comments

@fregante
Copy link
Collaborator

fregante commented Feb 7, 2024

Describe the bug

As seen in that PR, some parts of the form don't wrap well in tight viewports and they might need to be reviewed.

This might be classified as low priority or papercut. However after the MV3 sidePanel migration, more people will see it since the page editor will be smaller when the sidePanel is open.

To Reproduce

  1. Create Sidebar panel
  2. Leave both page editor sidebars open
  3. Make window tight enough that components feel cramped

Actual behavior

Screenshot 11 Screenshot 10

Expected behavior

They should wrap earlier.

Related

@fregante fregante added bug Something isn't working page editor labels Feb 7, 2024
@fregante
Copy link
Collaborator Author

fregante commented Feb 7, 2024

These two fields were also affected until #7464 was merged:

Screenshot 19 Screenshot 18

Now they don't suffer the same exact issue, but in one specific resolution they might end up in this layout instead (between 1516px and 1528px)

Screenshot 21

@BrandonPxBx
Copy link

The gap between the label and the input is too great once wrapped. However, this change is sorely needed, IMO. There's a bigger discussion going on about it, so copying Todd for visibility. CC @twschiller

@fregante
Copy link
Collaborator Author

The gap between the label and the input is too great once wrapped

True, there's a PR open to fix that. You can see the before/after in it:

@twschiller twschiller changed the title Improve page editor responsiveness further Improve page editor responsive UI further Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working page editor
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants