Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text Selection Menu never closes on Notion modals #8075

Closed
grahamlangford opened this issue Mar 27, 2024 · 1 comment · Fixed by #8096
Closed

Text Selection Menu never closes on Notion modals #8075

grahamlangford opened this issue Mar 27, 2024 · 1 comment · Fixed by #8096
Assignees
Labels
bug Something isn't working user experience Improve the user experience (UX)

Comments

@grahamlangford
Copy link
Collaborator

Describe the bug

In Notion, when a page modal is open and text is selected, clicking away does not close the menu. The same behavior does not happen when the page is opened as a full page.

To Reproduce

Steps to reproduce the behavior:

  1. Go to Notion
  2. Open the preview of a page (in a modal)
  3. Select text
  4. the Text Selection Menu is shown
  5. Click elsewhere in the modal

Actual behavior

The menu remains open in the same location. Highlighting other text moves the menu, but it does not appear possible to close it

Expected behavior

The menu should be dismissed

Screenshots/Loom

https://www.loom.com/share/47ae5403286e4d0fb793e8e5b6e83ad2

Desktop (please complete the following information):

  • Extension Version: 1.8.11
@grahamlangford grahamlangford added the bug Something isn't working label Mar 27, 2024
@fregante
Copy link
Collaborator

I'm gonna guess that they use stopPropagation so it never reaches our listener. Is our event already capture: true?

@twschiller twschiller added the user experience Improve the user experience (UX) label Mar 28, 2024
@fungairino fungairino self-assigned this Mar 29, 2024
@fungairino fungairino linked a pull request Mar 29, 2024 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working user experience Improve the user experience (UX)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants