#8075 ensure we capture events in selection menu handlers #8096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fungairino
changed the title
fungairino
commented
Mar 29, 2024
| @@ -48,12 +48,6 @@ export const selectionMenuActionRegistry = new ActionRegistry(); | |||
|
|
|||
| let selectionMenu: Nullishable<HTMLElement>; | |||
|
|
|||
| const onMousedownHide = (event: MouseEvent) => { | |||
There was a problem hiding this comment.
I moved this function closer to where it's used for better code organization
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8096 +/- ##
==========================================
- Coverage 73.20% 73.19% -0.01%
==========================================
Files 1310 1310
Lines 40730 40732 +2
Branches 7567 7569 +2
==========================================
- Hits 29816 29815 -1
- Misses 10914 10917 +3 ☔ View full report in Codecov by Sentry. |
grahamlangford
approved these changes
Mar 29, 2024
|
When the PR is merged, the first loom link found on this PR will be posted to |
fungairino
deleted the
8075-text-selection-menu-never-closes-on-notion-modals
branch
grahamlangford
pushed a commit
that referenced
this pull request
Mar 29, 2024
grahamlangford
added a commit
that referenced
this pull request
Apr 1, 2024
* get sidebar state in background * starter mods sidebar panels are closed on install * fix imports * add sidebarStorage to strictNullChecks * adds tests for sidebarStorage * adds more test coverage * add tests for getModComponentIdsForModComponentDefinitions * renaming * update factory to support overriding starterBrickType * revert factory changes * lint fixes * add troubleshooting section to e2e tests readme (#8095) * ensure we capture events in selection menu handlers (#8096) * pr-related fixes * Update src/background/starterMods.ts Co-authored-by: Ben Loe <below413@gmail.com> * fix types --------- Co-authored-by: Eduardo Fungairino <eduardo@pixiebrix.com> Co-authored-by: Ben Loe <below413@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Demo
Checklist