Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E test for activating a deployed mod successfully from the extension console #8647

Closed
fungairino opened this issue Jun 18, 2024 · 0 comments · Fixed by #8655
Closed

E2E test for activating a deployed mod successfully from the extension console #8647

fungairino opened this issue Jun 18, 2024 · 0 comments · Fixed by #8655
Assignees

Comments

@fungairino
Copy link
Collaborator

User Story

As a developer I want to have an e2e playwright test that covers activating a deployed mod successfully.

Motivation

#8645

More details

Use a separate test user account to avoid deployment conflicts with the main test user account.

extension-e2e-test.affiliated@pixiebrix.test
(password in 1password)

This user already has a team + deployment set up.

Sample e2e test:

import { test, expect } from "../../fixtures/testBase";

// @ts-expect-error -- https://youtrack.jetbrains.com/issue/AQUA-711/Provide-a-run-configuration-for-Playwright-tests-in-specs-with-fixture-imports-only
import { type Page, test as base } from "@playwright/test";

test("#8645 Deployments work", async ({ page }) => {
  // Deactivate the only mod
  await page.getByLabel("mods-page-actions").click();
  await page.getByRole("button", { name: "Deactivate" }).click();

  // Deployment modal should pop up. Click Activate
  await page.getByRole("button", { name: "Activate" }).click();

  // Wait for the error status to potentially pop up
  await page.waitForTimeout(1500);

  await expect(
    page.getByRole("status").getByText("Error updating team deployments"),
  ).toBeHidden();
  // make a better assertion that the mod was activated successfully
});

@fungairino fungairino self-assigned this Jun 18, 2024
@twschiller twschiller changed the title E2E test for activating a deployed mod successfully E2E test for activating a deployed mod successfully from the extension console Jun 19, 2024
@fungairino fungairino changed the title E2E test for activating a deployed mod successfully from the extension console #8647 E2E test for activating a deployed mod successfully from the extension console Jun 20, 2024
@fungairino fungairino changed the title #8647 E2E test for activating a deployed mod successfully from the extension console E2E test for activating a deployed mod successfully from the extension console Jun 20, 2024
fungairino added a commit that referenced this issue Jun 21, 2024
* custom profile name fixture + deployment activation spec

* fix lint errors

* add new env vars to ci

* fix types

* fix types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant