Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Page Editor EditorState name migration #8654

Closed
16 tasks done
grahamlangford opened this issue Jun 20, 2024 · 0 comments · Fixed by #8690
Closed
16 tasks done

Page Editor EditorState name migration #8654

grahamlangford opened this issue Jun 20, 2024 · 0 comments · Fixed by #8690
Assignees
@grahamlangford
Labels
developer experience page editor

Comments

@grahamlangford
Copy link
Collaborator

grahamlangford commented Jun 20, 2024 •
edited
Loading

Context/Motivation

  • Migrate EditorState keys to match renaming effort

Definition of Done

  • activeElementId -> activeModComponentId
  • activeRecipeId -> activeModId
  • expandedRecipeId -> expandedModId
  • elements -> modComponentFormStates
  • knownEditable -> knownEditableBrickIds
  • elementUIStates -> brickPipelineUIStateById
  • copiedBlock -> copiedBrick
  • dirtyRecipeOptionsById -> dirtyModOptionsById
  • dirtyRecipeMetadataById -> dirtyModMetadataById
  • addBlockLocation -> addBrickLocation
  • keepLocalCopyOnCreateRecipe -> keepLocalCopyOnCreateMod
  • deletedElementsByRecipeId -> deletedModComponentFormStatesByModId
  • availableInstalledIds -> availableActivatedModComponentIds
  • isPendingInstalledExtensions -> isPendingAvailableActivatedModComponents
  • availableDynamicIds -> availableDraftModComponentIds
  • isPendingDynamicExtensions -> isPendingDraftModComponents
@grahamlangford grahamlangford self-assigned this Jun 20, 2024
@twschiller twschiller changed the title EditorState Migration Page Editor EditorState name migration Jun 20, 2024
@grahamlangford grahamlangford mentioned this issue Jun 24, 2024
Merged
@grahamlangford grahamlangford linked a pull request Jun 24, 2024 that will close this issue
#8654: page editor editorstate name migration #8690
Merged
mnholtz added a commit that referenced this issue Jun 24, 2024
@grahamlangford @mnholtz
#8654: page editor editorstate name migration (#8690)
62c13bc 
* creates new EditorState type

* update selectors

* fix typings

* fix strict null checks

* implements migration

* adds test for migration

* fix capitalization of thunk; element -> modComponentFormState

* revert selectActiveModComponentTraces -> selectActiveElementTraces

* revert trace name change

* fix editorstate type comments

* fix error message in validateNodeUIState

---------

Co-authored-by: Misha Holtz <36575242+mnholtz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@grahamlangford grahamlangford

Labels
developer experience page editor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#8654: page editor editorstate name migration pixiebrix/pixiebrix-extension
1 participant
@grahamlangford