Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#575: Add proper permission for pixiebrix.com #1583

Merged
merged 1 commit into from Oct 6, 2021

Conversation

fregante
Copy link
Collaborator

@fregante fregante commented Oct 4, 2021

I verified that this change does not disable the extension using an unlisted extension:

  1. Installed extension that looked like:
    {
       "permissions": [ "storage" ]
    }
  2. Added a content script for https://*.pixiebrix.com/* (which is what we already have)
    {
    +   "content_scripts": [ {
    +      "css": [ "style.css" ],
    +      "matches": [ "https://*.pixiebrix.com/*" ],
    +      "run_at": "document_idle"
    +  } ],
       "permissions": [ "storage" ]
    }
  3. The extension was disabled as expected: ✅

Screen Shot 2

Screen Shot 3

  1. Then I added https://*.pixiebrix.com/* to the permissions array
    {
       "content_scripts": [ {
          "css": [ "style.css" ],
          "matches": [ "https://*.pixiebrix.com/*" ],
          "run_at": "document_idle"
       } ],
    -    "permissions": [ "storage" ]
    +    "permissions": [ "https://*.pixiebrix.com/*", "storage" ]
    }
  2. The extension was not disabled 🎉

@fregante fregante marked this pull request as ready for review October 4, 2021 13:04
@fregante fregante changed the title Add proper permission for pixiebrix.com #575: Add proper permission for pixiebrix.com Oct 4, 2021
@fregante fregante added the user experience Improve the user experience (UX) label Oct 4, 2021
@fregante
Copy link
Collaborator Author

fregante commented Oct 5, 2021

If you want to personally verify the changes (and also for future reference), here are the full versions I uploaded to the store:

@twschiller twschiller merged commit 06e8e21 into main Oct 6, 2021
@twschiller twschiller deleted the F/feature/app-pixiebrix-permissions branch October 6, 2021 14:28
@twschiller
Copy link
Contributor

Thanks for checking that it doesn't disable the extension!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
user experience Improve the user experience (UX)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minor issue: Devtools pane thinks it doesn't have access to app.pixiebrix.com
2 participants