#2856 Improve ContextError display in Page Editor output panel #2860
Conversation
BALEHOK
force-pushed
the
feature/2856-error-display
branch
from
710bdcd
to
f5513cf
Compare
BALEHOK
force-pushed
the
feature/2856-error-display
branch
from
a407006
to
f7f542c
Compare
| return <NetworkErrorDetail error={rootCause.error} />; | ||
| } | ||
|
|
||
| return entry.error.stack; |
There was a problem hiding this comment.
Do we need the stack trace for unknown errors?
There was a problem hiding this comment.
I think the only people who would understand the stack trace are probably capable of finding the stack trace in the browser console, right? Maybe we could show the first line of the stack trace or something? I'm just not sure when this would be useful to most page editor users.
There was a problem hiding this comment.
Honestly, I don't think that the first line will be of any help.
Agree with the rest of your comment.
There was a problem hiding this comment.
Ok, so should we remove this and just return a generic "unknown error occurred, please try again" type of message instead?
There was a problem hiding this comment.
The stack trace is removed, in case of "unknown" error it will show the name and message, see https://github.com/pixiebrix/pixiebrix-extension/pull/2860/files#diff-c412177eff772c4bca878f3bc805c720cbd34904f49e54cae4c8bc21fb850a5cR72
BALEHOK
changed the title
Closes #2856
ErrorDetails components are reused. The logic in
ErrorDisplayis very similar toEntryRowand can be moved to a helper/utility function.InputValidationError:
ClientNetworkError:
Template error (or any other error with the
nameproperty):Logs tab:
TODO:
ErrorDisplayandEntryRow