Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move entry points into their folders #2862

Merged
merged 1 commit into from Mar 4, 2022
Merged

Conversation

fregante
Copy link
Collaborator

@fregante fregante commented Mar 3, 2022

As previously suggested by Todd, this PR moves the entry points into their folders. I had initially thought about naming them background/main.ts but Todd suggested it's annoying to have many files with the same name laying around, so:

background.ts -> background/background.ts

For:

  • contentScript
  • background
  • options
  • sidebar

I moved small contexts that don't have their own sub-folders into a joint tinyPages folder. This only serves to clean up the src root and indeed it's looking quite clearer now.

  • tinyPages/ephemeralForm.tsx
  • tinyPages/permissionsPopup
  • tinyPages/frame.ts
  • tinyPages/devTools.ts (not to be confused with pageEditor)

I also merged the 2 global .d.ts files and moved the headers.ts to the development folder.

@fregante fregante marked this pull request as draft March 3, 2022 15:12
@fregante fregante marked this pull request as ready for review March 3, 2022 15:38
@fregante fregante added the small T-shirt sizing label Mar 3, 2022
@twschiller twschiller self-requested a review March 4, 2022 13:49
@twschiller twschiller merged commit cb922fb into main Mar 4, 2022
@twschiller twschiller deleted the F/lint/uhaul-folders branch March 4, 2022 13:50
@twschiller twschiller added this to the 1.5.6 milestone Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants