Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#3032: fix extension export on blueprints export page #3034

Merged
merged 5 commits into from Mar 27, 2022
Merged

#3032: fix extension export on blueprints export page #3034

merged 5 commits into from Mar 27, 2022

Conversation

twschiller
Copy link
Contributor

@twschiller twschiller commented Mar 26, 2022 •
edited

Closes #3032

  • Fix types and throw on violated pre-condition
  • Fix calls to share/export

@twschiller twschiller requested a review from mnholtz March 26, 2022 21:18
@twschiller twschiller marked this pull request as draft March 26, 2022 21:19
@twschiller twschiller marked this pull request as ready for review March 27, 2022 14:21
@twschiller twschiller changed the title #3032: [WIP] fix types on export #3032: fix extension export on blueprints export page Mar 27, 2022
@twschiller twschiller merged commit aac6fe2 into main Mar 27, 2022
@twschiller twschiller deleted the feature/3032-blueprint-export branch March 27, 2022 14:57
@twschiller twschiller added this to the 1.5.9 milestone Mar 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnholtz mnholtz Awaiting requested review from mnholtz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.5.9
Development

Successfully merging this pull request may close these issues.

Blueprint export broken - exports internal identifier instead of definitions section
1 participant
@twschiller