Handle closed tabs better while attempting to message them #3572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fregante
changed the title
fregante
commented
Jun 6, 2022
| const tabToOpener = new Map<TabId, TabId>(); | ||
| const tabToTarget = new Map<TabId, TabId>(); | ||
| // TODO: One tab could have multiple targets, but `tabToTarget` currenly only supports one at a time | ||
|
|
||
| async function safelyRunBrick({ tabId }: { tabId: number }, request: RunBlock) { | ||
| if (!(await canAccessTab(tabId))) { |
There was a problem hiding this comment.
Since this was being run first, it was reporting "no access" when the tab just didn't exist (was closed way too early).
Here you can see different error messages depending on how long I wait before closing the tab.
Screen.Recording.42.mov
Comment on lines
-48
to
-52
| const result = await Promise.race([ | ||
| // If https://github.com/pixiebrix/webext-messenger/issues/67 is resolved, we don't need the listener | ||
| onTabClose(tabId).then(() => TYPE_WAS_CLOSED), | ||
| runBrick({ tabId }, request), | ||
| ]); |
There was a problem hiding this comment.
I think there was a race condition (heh) right here. If onTabClose resolved in time, we'd get "was closed". If not, we'd get the raw Chrome error because it would not be handled by this code at all.
You can see the two error message alternating here.
alternate.mov
Note
This alternating of message hasn't really been fixed by this PR.
Before
- BusinessError: PixieBrix doesn't have access to the tab
- BusinessError: The tab was closed
- Error: A listener indicated an asynchronous response by returning true, but the message channel closed before a response was received
After
- BusinessError: The target was closed before receiving a response
- BusinessError: The tab doesn't exist
Both are "tab doesn't exist" errors but sometimes we can track why it doesn't exist, so we can throw "tab was closed" instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This new behavior was fixed in the messenger itself:
Nit: unless we install a global tab tracker, it's hard to tell whether a tab ever existed.
Demo
targetDepending on how quickly the target is closed, the error will either be "tab doesn't exist" or "tab closed"
Screen.Recording.8.mov
Future Work
I should probably fix this permanently: