Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4499 add PackageVersion to invalidated tags on updatePackage mutation #4586

Merged
merged 1 commit into from Nov 2, 2022

Conversation

mnholtz
Copy link
Collaborator

@mnholtz mnholtz commented Nov 1, 2022

What does this PR do?

Demo

Screen.Recording.2022-11-01.at.4.34.55.PM.mov

Checklist

  • Add tests
  • Run Storybook and manually confirm that all stories are working
  • Designate a primary reviewer @BLoe

@mnholtz mnholtz changed the title add PackageVersion to invalidated tags on updatePackage mutation #4499add PackageVersion to invalidated tags on updatePackage mutation Nov 1, 2022
@mnholtz mnholtz changed the title #4499add PackageVersion to invalidated tags on updatePackage mutation #4499 add PackageVersion to invalidated tags on updatePackage mutation Nov 1, 2022
@codecov
Copy link

codecov bot commented Nov 1, 2022

Codecov Report

Merging #4586 (316cc61) into main (d8c8a5c) will increase coverage by 0.01%.
The diff coverage is 92.30%.

@@            Coverage Diff             @@
##             main    #4586      +/-   ##
==========================================
+ Coverage   50.62%   50.63%   +0.01%     
==========================================
  Files         912      913       +1     
  Lines       26949    26959      +10     
  Branches     5462     5463       +1     
==========================================
+ Hits        13642    13651       +9     
- Misses      12377    12378       +1     
  Partials      930      930              
Impacted Files Coverage Δ
src/blocks/readers/SelectionReader.ts 0.00% <ø> (ø)
src/contentScript/sidebarDomControllerLite.ts 19.04% <0.00%> (-0.47%) ⬇️
src/services/api.ts 40.35% <ø> (ø)
src/components/DelayedRender.tsx 100.00% <100.00%> (ø)
src/components/Loader.tsx 100.00% <100.00%> (ø)
src/sidebar/ConnectedSidebar.tsx 70.27% <100.00%> (+0.82%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@twschiller twschiller added this to the 1.7.12 milestone Nov 2, 2022
@mnholtz mnholtz merged commit b551d75 into main Nov 2, 2022
@mnholtz mnholtz deleted the bugfix/4499_fix_missing_current_version_of_brick branch November 2, 2022 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot view diff of current version of brick vs. historic versions in the Workshop
2 participants