New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#5575 Configuration options styling #5617
Conversation
Added @mnholtz and @BrandonPxBx as FYI. PR/code changes are still in flux currently |
…feature/5576-configuration-accordion
Codecov Report
@@ Coverage Diff @@
## main #5617 +/- ##
==========================================
- Coverage 64.43% 64.32% -0.11%
==========================================
Files 1031 1031
Lines 32438 32414 -24
Branches 6155 6155
==========================================
- Hits 20900 20850 -50
- Misses 11538 11564 +26
|
@@ -42,13 +42,18 @@ $border: rgba(0, 0, 0, 0.3); | |||
display: flex; | |||
align-items: center; | |||
cursor: move; | |||
|
|||
padding: 12px; | |||
background: #ddd; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Would you add this color to colors.scss
and import it as a variable, e.g.
@import "@/themes/colors"; |
You can give it an arbitrary name that makes sense because it's not in our Design System. We are attempting to start collecting hard-coded values as css variables as part of a first step in improving the state of our design system.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See this PR for context: #4726
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Understood. I'll address both.
padding: 8px; | ||
border-radius: 4px; | ||
font-weight: 500; | ||
background: #f8f9fa; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: see other comment re refactoring this into a color in colors.scss
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just had a small question about the CSS class that you added, LGTM otherwise 👍
"matching elements" | ||
)}`} | ||
</div> | ||
<div className="d-flex align-items-center popover-wrapper-body"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the effect of adding popover-wrapper-body
here? Was this moved from somewhere else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just styling. FieldSection
was providing some padding but since I replaced it with a div
I'm using this for padding.
When the PR is merged, the first loom link found on this PR will be posted to |
What does this PR do?
AccordionFieldSection
for advanced options (uncontrolled, next story addresses that)FieldSection
ArrayWidget
Demo
Future Work
Checklist