Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#6284: Generic PKCE refresh token function #6291

Merged
merged 11 commits into from Aug 22, 2023

Conversation

johnnymetz
Copy link
Collaborator

@johnnymetz johnnymetz commented Aug 18, 2023

What does this PR do?

Demo

https://www.loom.com/share/e64712d238104e38b7455cda52ec5af5

Checklist

@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Merging #6291 (6f9dbf3) into main (716ccfa) will decrease coverage by 0.01%.
Report is 2 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #6291      +/-   ##
==========================================
- Coverage   69.75%   69.74%   -0.01%     
==========================================
  Files        1151     1151              
  Lines       36001    36008       +7     
  Branches     6765     6772       +7     
==========================================
+ Hits        25112    25115       +3     
- Misses      10889    10893       +4     
Files Changed Coverage Δ
src/services/constants.ts 100.00% <ø> (ø)
src/types/integrationTypes.ts 100.00% <ø> (ø)
src/background/refreshToken.ts 100.00% <100.00%> (ø)
src/background/requests.ts 91.11% <100.00%> (+0.13%) ⬆️
src/services/factory.ts 74.24% <100.00%> (+0.80%) ⬆️

... and 2 files with indirect coverage changes

@twschiller twschiller added this to the 1.7.37 milestone Aug 18, 2023
@grahamlangford
Copy link
Collaborator

LGTM. Need to add the UiPath refresh.

Co-authored-by: Graham Langford <30706330+grahamlangford@users.noreply.github.com>
@johnnymetz
Copy link
Collaborator Author

Ready for a final review. Just added a demo video.

@github-actions
Copy link

When the PR is merged, the first loom link found on this PR will be posted to #sprint-demo on Slack. Do not edit this comment manually.

@johnnymetz johnnymetz merged commit fe297d0 into main Aug 22, 2023
11 checks passed
@johnnymetz johnnymetz deleted the feature/6284-generic-refresh-token branch August 22, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatically Refresh Authentication for MS Azure and other integrations
3 participants