Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop front-end framework detection code #6776

Merged
merged 3 commits into from Oct 31, 2023
Merged

Conversation

twschiller
Copy link
Contributor

@twschiller twschiller commented Oct 31, 2023

What does this PR do?

  • Drops framework detection code used by Page Editor
  • Drops the custom Component Reader options in the Page Editor
  • Keeps functionality required for existing mods to work (see Component Reader and Set Vue Values)
  • Dropping the code makes the page script a little smaller

Discussion

  • For manual test plan, @mthek10 can help validate on the test sites for customers still on the Component Reader and Set Vue Value bricks

Screenshot

image

Checklist

  • Add tests
  • New files added to src/tsconfig.strictNullChecks.json (if possible)
  • Designate a primary reviewer: @grahamlangford

@twschiller twschiller self-assigned this Oct 31, 2023
@twschiller twschiller changed the title Drop framework detection code Drop front-end framework detection code Oct 31, 2023
Copy link
Collaborator

@fregante fregante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack.

Do not edit this comment manually.

@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (aefc3e5) 70.03% compared to head (f313397) 70.13%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6776      +/-   ##
==========================================
+ Coverage   70.03%   70.13%   +0.10%     
==========================================
  Files        1193     1190       -3     
  Lines       36967    36897      -70     
  Branches     6939     6923      -16     
==========================================
- Hits        25888    25877      -11     
+ Misses      11079    11020      -59     
Files Coverage Δ
...c/bricks/transformers/component/ComponentReader.ts 64.70% <ø> (ø)
src/contentScript/messenger/api.ts 100.00% <ø> (ø)
src/contentScript/messenger/registration.ts 0.00% <ø> (ø)
src/contentScript/pageEditor/elementPicker.ts 67.35% <100.00%> (+0.27%) ⬆️
src/contrib/editors.ts 0.00% <ø> (ø)
src/pageEditor/fields/SelectorSelectorWidget.tsx 64.36% <ø> (-0.41%) ⬇️
...ditor/fields/selectorListItem/SelectorListItem.tsx 100.00% <100.00%> (ø)
src/pageEditor/panes/insert/useAutoInsert.ts 0.00% <ø> (ø)
src/pageEditor/starterBricks/formStateTypes.ts 94.44% <ø> (ø)
src/pageEditor/tabState/tabStateSlice.ts 63.46% <ø> (+4.13%) ⬆️
... and 7 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@twschiller twschiller merged commit 95ca769 into main Oct 31, 2023
14 checks passed
@twschiller twschiller deleted the feature/drop-framework-code branch October 31, 2023 11:12
@grahamlangford grahamlangford added this to the 1.8.2 milestone Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants